Remove never-wired input-gain API; CHANGELOG + 1.2.0 release prep#24
Merged
Conversation
…lease docs - Remove input-gain attribute and inputGain property (never wired to a GainNode; gain is permanently a host responsibility via the host-gain pattern) from element, types, docs, and agent docs - Add CHANGELOG.md (Keep a Changelog): [Unreleased] removal entry with consumer-impact and semver policy notes; backfill 1.0.0-1.1.0 from tags - Ship CHANGELOG.md in the npm tarball (files[] — npm does not auto-include changelogs) - Rewrite Phase 7 per-release checklist with ordered release flow (push --follow-tags only after npm publish to avoid CDN 404 window); align SESSION_HANDOFF release procedure with it - Drop planned-v2 signal-type from the api.md primary example - Complete CLAUDE.md dev-commands block (typecheck, demo, build variants) - Supersession markers for stale input-gain guidance in CLAUDE_REVIEW.md Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input-gainattribute andinputGainproperty from the component, TypeScript declarations, and all docs. They were documented and typed but never wired to aGainNode— setting them had no effect in any released version. Input gain is permanently a host responsibility via the host-gain pattern (docs/examples/host-gain.md). Decision: permanent drop, not deferred to v2.CHANGELOG.md(Keep a Changelog):[Unreleased]entry for the removal — naming both the property/attribute and theobservedAttributeschange, plus the semver policy note — and backfilled entries for 1.0.0 / 1.0.1 / 1.0.2 / 1.1.0 from git tags.CHANGELOG.mdadded topackage.jsonfiles[](npm does not auto-include changelogs in tarballs).agents/CLAUDE_REVIEW.mdrewritten with the ordered flow (changelog stamp + CDN pin bump in a prep commit onmain,git push --follow-tagsonly afternpm publish— avoids the Pages-deploy CDN 404 window).SESSION_HANDOFF.mdrelease procedure aligned; staleinput-gainguidance superseded with dated markers.signal-typeremoved from thedocs/api.mdprimary example;CLAUDE.mddev-commands block completed (typecheck,demo,build:component:dev,build:component:all).This PR deliberately does not stamp the changelog to
[1.2.0]or bump the CDN pins — those happen in the release prep commit onmainafter merge, per the Phase 7 checklist.Verification
npm run typecheck✅npm test✅ (all pass)npm run build:component:all✅npm run docs:build✅npm pack --dry-run✅ (13 files incl. CHANGELOG.md; rebuiltdist/index.d.tshas noinputGain)🤖 Generated with Claude Code